Sign .js release files in addition to .tar.gz files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References yarnpkg/yarn#2728 References nodejs/docker-node#243
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of all the files in the releases (eg. https://github.com/yarnpkg/yarn/releases/tag/v0.20.3), only the tarball and the MSI are signed. The tarball is signed using GPG, and the MSI is signed using an Authenticode certificate. Additionally, the .deb is signed as part of the Debian repo, but the individual file on Github is not signed.
This PR updates the signing code to also sign the standalone
.jsfiles, so they can also be verified.References yarnpkg/yarn#2728
References nodejs/docker-node#243